Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: port throw meaningful exception #3163

Merged
merged 1 commit into from
Dec 29, 2020
Merged

fix: port throw meaningful exception #3163

merged 1 commit into from
Dec 29, 2020

Conversation

joshgummersall
Copy link
Contributor

Fixes #3158

@joshgummersall joshgummersall requested review from a team as code owners December 28, 2020 17:39
@coveralls
Copy link

coveralls commented Dec 28, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 449241023

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 84.365%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/input/inputDialog.ts 9 83.04%
Totals Coverage Status
Change from base Build 443119412: 0.002%
Covered Lines: 17641
Relevant Lines: 19978
💛 - Coveralls

@joshgummersall joshgummersall merged commit 531af99 into main Dec 29, 2020
@joshgummersall joshgummersall deleted the jpg/port-throw-meaningful-exception branch December 29, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricDahlvang EricDahlvang EricDahlvang approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Throw a meaningful exception if InputDialog.Prompt is missing (#5065)
3 participants
@joshgummersall @coveralls @EricDahlvang