Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replaced entityRecognizers with externalEntityRecognizer in OrchestratorAdaptiveRecognizer #3151

Merged
merged 7 commits into from
Dec 24, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Dec 16, 2020

Fixes #3115

Description

Replaced entityRecognizers with externalEntityRecognizer in OrchestratorAdaptiveRecognizer

Specific Changes

  • replaced entityRecognizers with externalEntityRecognizer in OrchestratorAdaptiveRecognizer
  • updated OrchestratorRecognizer
  • moved createChooseIntentResult to Recognizer
  • removed unused dependencies in botbuilder-ai-orchestrator

Testing

Updated test cases for orchestrator

@chon219 chon219 added the Area: AI-Orchestrator The issue is related to Orchestrator label Dec 16, 2020
@chon219 chon219 added this to the R12 milestone Dec 16, 2020
@chon219 chon219 requested review from a team as code owners December 16, 2020 10:24
@chon219 chon219 changed the title fix: replaced entityRecognizers with externalEntityRecognizer in OrchestratorAdaptiveRecognizer feat: replaced entityRecognizers with externalEntityRecognizer in OrchestratorAdaptiveRecognizer Dec 16, 2020
@coveralls
Copy link

coveralls commented Dec 16, 2020

Pull Request Test Coverage Report for Build 441941263

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 41 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.0009%) to 84.295%

Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.63%
libraries/botbuilder-dialogs/src/recognizer.ts 3 88.89%
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts 4 33.33%
libraries/adaptive-expressions/src/triggerTrees/node.ts 10 90.51%
libraries/botbuilder-ai-orchestrator/src/orchestratorAdaptiveRecognizer.ts 22 61.03%
Totals Coverage Status
Change from base Build 438328356: 0.0009%
Covered Lines: 17628
Relevant Lines: 19979

💛 - Coveralls

Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple quick comments.

@joshgummersall joshgummersall merged commit 969739c into main Dec 24, 2020
@joshgummersall joshgummersall deleted the zim/orchestrator-recognizer branch December 24, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: AI-Orchestrator The issue is related to Orchestrator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Align OrchestratorRecognizer with LuisRecognizer ExternalEntityRecognizer (#4995)
3 participants