Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cycle references support #3141

Merged
merged 5 commits into from
Dec 14, 2020
Merged

feat: cycle references support #3141

merged 5 commits into from
Dec 14, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Dec 10, 2020

Fixes #2640

Description

Allow ResourceExplorer to preload types into cache to support cycle references between dialog files.

Specific Changes

  • allow ResourceExplorer to preload types
  • updated container registration in DialogManager to avoid infinite loops
  • updated telemetry client configuration in DialogContainer to avoid infinite loops

Testing

Added tests to cover cycle references.

@chon219 chon219 added the Area: Adaptive The issue is related to Adaptive dialogs label Dec 10, 2020
@chon219 chon219 added this to the R12 milestone Dec 10, 2020
@chon219 chon219 requested review from a team as code owners December 10, 2020 13:29
@chon219 chon219 requested a review from tomlm December 10, 2020 13:29
@coveralls
Copy link

coveralls commented Dec 10, 2020

Pull Request Test Coverage Report for Build 421234524

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.003%) to 84.48%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs/src/dialogManager.ts 1 92.77%
libraries/botbuilder-dialogs-declarative/src/resources/resourceExplorer.ts 7 81.33%
Totals Coverage Status
Change from base Build 420115944: 0.003%
Covered Lines: 17656
Relevant Lines: 19971

💛 - Coveralls

@joshgummersall joshgummersall merged commit 5ae13ca into main Dec 14, 2020
@joshgummersall joshgummersall deleted the zim/cycle-detection branch December 14, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Adaptive The issue is related to Adaptive dialogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] Declarative: Fix Cycle detection issues with partial graph knowledge.
3 participants