Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: plumb http agent into documentdb client #3139

Merged
merged 2 commits into from
Dec 14, 2020
Merged

fix: plumb http agent into documentdb client #3139

merged 2 commits into from
Dec 14, 2020

Conversation

joshgummersall
Copy link
Contributor

This is definitely the sketchiest implementation, though I've verified it with the locally installed dependencies. It's also very defensive and purely opt-in.

@joshgummersall joshgummersall force-pushed the jpg/bb-azure-cosmos-agent branch from 01b6502 to 878c9d5 Compare December 9, 2020 23:19
@coveralls
Copy link

coveralls commented Dec 9, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 421740900

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 84.467%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-azure/src/cosmosDbStorage.ts 12 83.7%
Totals Coverage Status
Change from base Build 421599425: 0.1%
Covered Lines: 17657
Relevant Lines: 19975
💛 - Coveralls

@joshgummersall joshgummersall force-pushed the jpg/bb-azure-cosmos-agent branch from 878c9d5 to be24369 Compare December 11, 2020 16:42
stevengum
stevengum reviewed Dec 14, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually this sounds great, but I had some questions about the future. Is there a version of the Cosmos DB SDK for JS that we should bump to? Should we make breaking changes in our API now to catch-up and avoid potential technical debt?

@stevengum stevengum requested a review from a team as a code owner December 14, 2020 21:11
stevengum
stevengum approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed, my bad for not seeing which class was being updated.

:shipit:

@joshgummersall joshgummersall merged commit eeb2e36 into main Dec 14, 2020
@joshgummersall joshgummersall deleted the jpg/bb-azure-cosmos-agent branch December 14, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshgummersall @coveralls @stevengum