feat: overhaul connector tests #3138

joshgummersall · 2020-12-09T23:11:50Z

provide OAuth/JWT stub helpers
expand JWT token validation tests
reorg existing auth tests
remove unnecessary assertExt helpers.

The bulk of this work is to protect me from inadvertent bugs caused by the incoming CloudAdapter port work. In particular, having a way to stub and test JWT/Oauth end-to-end with full signature verification is handy.

coveralls · 2020-12-09T23:22:58Z

Pull Request Test Coverage Report for Build 480958776

0 of 0 changed or added relevant lines in 0 files are covered.
35 unchanged lines in 6 files lost coverage.
Overall coverage increased (+0.09%) to 84.479%

Files with Coverage Reduction	New Missed Lines	%
libraries/botframework-connector/src/auth/appCredentials.ts	1	90.91%
libraries/botframework-connector/src/auth/governmentChannelValidation.ts	2	89.13%
libraries/botframework-connector/src/auth/microsoftAppCredentials.ts	2	77.78%
libraries/botframework-connector/src/auth/jwtTokenValidation.ts	6	88.89%
libraries/botframework-connector/src/auth/emulatorValidation.ts	10	73.4%
libraries/botframework-connector/src/auth/jwtTokenExtractor.ts	14	71.68%

Totals
Change from base Build 480938929:	0.09%
Covered Lines:	17807
Relevant Lines:	20138

💛 - Coveralls

libraries/botbuilder-stdlib/src/assertExt.ts

libraries/botframework-connector/src/auth/skillValidation.ts

libraries/botframework-connector/src/connectorApi/connectorClient.ts

libraries/botframework-connector/tests/auth.test.js

joshgummersall · 2020-12-11T22:39:40Z

testing/botbuilder-test-utils/src/jwt.ts

@@ -0,0 +1,127 @@
+// Copyright (c) Microsoft Corporation.


This magically allows us to fully stub JWT in the tests.

joshgummersall · 2020-12-11T22:39:59Z

testing/botbuilder-test-utils/src/oauth.ts

@@ -0,0 +1,65 @@
+// Copyright (c) Microsoft Corporation.


And this the Oauth flow, including fully signed and verifiable JWTs (using the above stub).

- provide oauth/jwt stub helpers in new test utils package - expand jwt token validation tests - reorg existing auth tests - remove unnecessary `assertExt` helpers. - JSDoc cleanup, code formatting, etc.

stevengum

This looks very solid. Should this PR be crosslinked with microsoft/botframework-sdk#5977 for the new botbuilder-test-utils nock-ing code?

joshgummersall requested review from axelsrz, carlosscastro, johnataylor, stevengum and a team as code owners December 9, 2020 23:11

joshgummersall force-pushed the jpg/add-bf-connector-tests branch 2 times, most recently from 81904f6 to cf3952b Compare December 9, 2020 23:16

microsoft deleted a comment from coveralls Dec 9, 2020

joshgummersall force-pushed the jpg/add-bf-connector-tests branch 3 times, most recently from 25d193f to c2f71c1 Compare December 11, 2020 21:57