Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tags to browser CI resource groups #3131

Merged
merged 2 commits into from
Dec 7, 2020
Merged

fix: add tags to browser CI resource groups #3131

merged 2 commits into from
Dec 7, 2020

Conversation

stevengum
Copy link
Member

Description

Adds tags to the provisioned Azure Resource Group for automated management of RGs.

These tags indicate when and why the Resource Group was created. They also provide pointers to the repository, the source branch and name of the pipeline that was run to better assist other team members with figuring out who to contact.

Specific Changes

  • Add tags to az group create step
  • Create $DateTimeTag runtime variable in Azure DevOps
    • A REST call is required to get the actual pipeline queue time, which didn't seem necessary for the goals of this PR.

@stevengum stevengum added the Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. label Dec 7, 2020
@stevengum stevengum requested a review from a team as a code owner December 7, 2020 18:40
@coveralls
Copy link

coveralls commented Dec 7, 2020

Pull Request Test Coverage Report for Build 406787824

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 84.494%

Totals Coverage Status
Change from base Build 406546364: 0.04%
Covered Lines: 17610
Relevant Lines: 19918

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants