Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use matrix for operating system #3125

Merged
merged 1 commit into from
Dec 4, 2020
Merged

fix: use matrix for operating system #3125

merged 1 commit into from
Dec 4, 2020

Conversation

joshgummersall
Copy link
Contributor

I didn't know this was supported!

@joshgummersall joshgummersall requested a review from a team as a code owner December 4, 2020 22:55
stevengum
stevengum approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! :shipit:

@coveralls
Copy link

coveralls commented Dec 4, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 401693446

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 84.376%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 85.0%
libraries/adaptive-expressions/src/triggerTrees/node.ts 2 95.26%
Totals Coverage Status
Change from base Build 401676565: -0.01%
Covered Lines: 17554
Relevant Lines: 19877
💛 - Coveralls

@joshgummersall joshgummersall merged commit e073a6e into main Dec 4, 2020
@joshgummersall joshgummersall deleted the jpg/gh-actions-os-matrix branch December 4, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshgummersall @coveralls @stevengum