Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow resource explorer to accept the set of declarative type registrations #3123

Merged
merged 7 commits into from
Dec 11, 2020
Merged

Allow resource explorer to accept the set of declarative type registrations #3123

merged 7 commits into from
Dec 11, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Dec 4, 2020

Fixes #3019

Description

Allow resource explorer to accept the set of declarative type registrations.

Specific Changes

  • Added ResourceExplorerOptions

Testing

@chon219 chon219 added this to the R12 milestone Dec 4, 2020
@chon219 chon219 requested a review from a team as a code owner December 4, 2020 09:10
@chon219 chon219 requested review from Stevenic and tomlm December 4, 2020 09:10
@coveralls
Copy link

coveralls commented Dec 4, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 414346058

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 84.485%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 63.08%
libraries/botbuilder-dialogs-declarative/src/resources/resourceExplorer.ts 12 80.92%
Totals Coverage Status
Change from base Build 411777892: -0.03%
Covered Lines: 17624
Relevant Lines: 19936
💛 - Coveralls

joshgummersall
joshgummersall approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny suggestion, otherwise this looks great!

@chon219 chon219 merged commit d7de0b3 into main Dec 11, 2020
@chon219 chon219 deleted the zim/resource-explorer-options branch December 11, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.

[PORT] Allow resource explorer to accept the set of declarative type registrations
3 participants
@chon219 @coveralls @joshgummersall