Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed timeout in OAuthInput #3112

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Fixed timeout in OAuthInput #3112

merged 1 commit into from
Dec 4, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Dec 3, 2020

Fixes #3023

Description

Fixed timeout logic in OAuthInput

Specific Changes

Testing

@chon219 chon219 added the Area: Adaptive The issue is related to Adaptive dialogs label Dec 3, 2020
@chon219 chon219 added this to the R12 milestone Dec 3, 2020
@chon219 chon219 requested a review from a team as a code owner December 3, 2020 08:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 397927471

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 58 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 84.753%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/node.ts 8 91.7%
libraries/botbuilder-dialogs-adaptive/src/input/oauthInput.ts 50 54.79%
Totals Coverage Status
Change from base Build 397125612: -0.05%
Covered Lines: 17344
Relevant Lines: 19537
💛 - Coveralls

@chon219 chon219 merged commit f9b37c4 into main Dec 4, 2020
@chon219 chon219 deleted the zim/oauth-input-timeout branch December 4, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
Area: Adaptive The issue is related to Adaptive dialogs
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.

[PORT] Fix the timeout login in OAuthInput
3 participants
@chon219 @coveralls @joshgummersall