Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register container dialogs in DialogManager #3105

Merged
merged 10 commits into from
Dec 7, 2020
Merged

Register container dialogs in DialogManager #3105

merged 10 commits into from
Dec 7, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Dec 2, 2020

Fixes #3038

Description

Register container dialogs in DialogManager and fix ReplaceDialog

Specific Changes

  • implemented getDialogs() of DialogSet
  • register container dialogs in DialogManager
  • fix ReplaceDialog

Testing

Added tests for DialogManager and ReplaceDialog.

@chon219 chon219 added the Area: Adaptive The issue is related to Adaptive dialogs label Dec 2, 2020
@chon219 chon219 added this to the R12 milestone Dec 2, 2020
@chon219 chon219 requested review from a team as code owners December 2, 2020 10:19
@chon219 chon219 requested a review from tomlm December 2, 2020 10:19
@coveralls
Copy link

coveralls commented Dec 2, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 405234156

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 84.443%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs/src/dialogManager.ts 6 92.5%
Totals Coverage Status
Change from base Build 401718224: 0.05%
Covered Lines: 17573
Relevant Lines: 19885
💛 - Coveralls

@joshgummersall joshgummersall merged commit 1c06b7a into main Dec 7, 2020
@joshgummersall joshgummersall deleted the zim/register-container-dialogs branch December 7, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
Area: Adaptive The issue is related to Adaptive dialogs
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.

[PORT] Adaptive: Container dialogs registered in dialog manager and ReplaceDialog now works
3 participants
@chon219 @coveralls @joshgummersall