Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xml And xPath prebuilt function #3093

Merged
merged 9 commits into from
Dec 4, 2020
Merged

Add xml And xPath prebuilt function #3093

merged 9 commits into from
Dec 4, 2020

Conversation

cosmicshuai
Copy link
Contributor

@cosmicshuai cosmicshuai commented Nov 26, 2020

Add xml and xPath pre-built functions to Adaptive-Expressions

xml and xPath can run in both browser and nodejs environment.

@coveralls
Copy link

coveralls commented Nov 27, 2020

Pull Request Test Coverage Report for Build 401152542

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 84.696%

Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/node.ts 2 95.26%
Totals Coverage Status
Change from base Build 401147845: -0.1%
Covered Lines: 17395
Relevant Lines: 19609

💛 - Coveralls

@cosmicshuai
Copy link
Contributor Author

cosmicshuai commented Nov 27, 2020

Removed type definition of x2js package due to it use 'Omit' in index.d.ts. This only works for typescript version >= 3.5.0
This will cause yarn test:consumer failure.

"../../node_modules/@types/xml2js/index.d.ts(95,23): error TS2304: Cannot find name 'Omit'.\n",

@cosmicshuai cosmicshuai marked this pull request as ready for review November 27, 2020 07:47
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick ask to remove unnecessary private method JSDoc comments.

@joshgummersall joshgummersall merged commit 33fa1e0 into main Dec 4, 2020
@joshgummersall joshgummersall deleted the shuwan/xmlxpath branch December 4, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants