Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adaptive-expressions-ie11 webpack config #3090

Merged
merged 2 commits into from
Nov 24, 2020
Merged

fix: adaptive-expressions-ie11 webpack config #3090

merged 2 commits into from
Nov 24, 2020

Conversation

joshgummersall
Copy link
Contributor

  • Use require.resolve for proper package resolution algorithm, do not
    hardcode paths to packages
  • Use CleanWebpackPlugin
  • Use CopyWebpackPlugin instead of copyfiles for proper package
    resolution algorithm

Replaces #3087

@joshgummersall joshgummersall requested review from stevengum and a team as code owners November 24, 2020 17:01
@joshgummersall
Copy link
Contributor Author

@atishayv please review this when you get a chance.

@joshgummersall joshgummersall force-pushed the jpg/fix-webpack-config branch 2 times, most recently from 9650067 to 7818e3f Compare November 24, 2020 17:05
fix: adaptive-expressions-ie11 webpack config
65c70b1 
- Use `require.resolve` for proper package resolution algorithm, do not
hardcode paths to packages
- Use `CleanWebpackPlugin`
- Remove `copyfiles` step as the Typescript compiler will properly
resolve type files

Replaces #3087
@joshgummersall joshgummersall mentioned this pull request Nov 24, 2020
Closed
@atishayv
Copy link
Contributor

@atishayv please review this when you get a chance.

Thanks for fixing my PR. The changes looks good to me

stevengum
stevengum approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since @atishayv signed off... :shipit:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 381596926

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 84.772%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.63%
Totals Coverage Status
Change from base Build 380166669: 0.02%
Covered Lines: 17348
Relevant Lines: 19539
💛 - Coveralls

@joshgummersall joshgummersall merged commit 60f92d3 into main Nov 24, 2020
@joshgummersall joshgummersall deleted the jpg/fix-webpack-config branch November 24, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshgummersall @atishayv @coveralls @stevengum