Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New action: ThrowException #3081

Merged
merged 12 commits into from
Dec 11, 2020
Merged

New action: ThrowException #3081

merged 12 commits into from
Dec 11, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Nov 23, 2020

Fixes #3025

Description

Added ThrowException action.

Specific Changes

  • New action: ThrowException
  • Make name/message/stack of DialogContextError enumerable to be accessed via expressions.

Testing

Added tests for the new action.

@chon219 chon219 added the Area: Adaptive The issue is related to Adaptive dialogs label Nov 23, 2020
@chon219 chon219 requested review from a team as code owners November 23, 2020 02:48
@coveralls
Copy link

coveralls commented Nov 23, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 414318964

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 84.503%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs/src/dialogContextError.ts 2 85.19%
Totals Coverage Status
Change from base Build 411777892: -0.008%
Covered Lines: 17633
Relevant Lines: 19944
💛 - Coveralls

joshgummersall
joshgummersall suggested changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions.

@joshgummersall joshgummersall merged commit 09f9d63 into main Dec 11, 2020
@joshgummersall joshgummersall deleted the zim/throw-exception branch December 11, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@stevengum stevengum stevengum left review comments

@Stevenic Stevenic Awaiting requested review from Stevenic

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
Area: Adaptive The issue is related to Adaptive dialogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] Add ThrowException action to pass exception out for string error message
4 participants
@chon219 @coveralls @joshgummersall @stevengum