Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create parity issue workflow #3080

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Conversation

joshgummersall
Copy link
Contributor

This workflow will create a parity issue that includes a short summary
and a link to a pull request, along with the parity label, to keep us
honest!

It will trigger on manual dispatch - actions will need to be added to
other repos to trigger this workflow.

@joshgummersall joshgummersall requested a review from a team as a code owner November 20, 2020 21:21
joshgummersall added a commit to microsoft/botbuilder-dotnet that referenced this pull request Nov 20, 2020
This will remotely trigger the workflow introduced via
microsoft/botbuilder-js#3080
@joshgummersall
Copy link
Contributor Author

The relevant dotnet PR is here: microsoft/botbuilder-dotnet#4997

@joshgummersall
Copy link
Contributor Author

Here is a sample issue from testing against some of my personal repos: https://github.com/joshgummersall/ts-plugin-mvp/issues/29

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, in the future we might have to write a custom workflow to get to where we want (i.e. if some change occurs in the *.sln or *.csproj files in .NET we likely don't need those changes in JS or Python)

Also, it seems like it might be possible to get the PRs linked issue according to this this doc page.

(Reached via https://docs.github.com/en/free-pro-team@latest/developers/webhooks-and-events/webhook-events-and-payloads#pull_request)

@stevengum
Copy link
Member

stevengum commented Nov 20, 2020

@coveralls
Copy link

coveralls commented Nov 20, 2020

Pull Request Test Coverage Report for Build 375315638

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 84.778%

Totals Coverage Status
Change from base Build 371483751: -0.007%
Covered Lines: 17312
Relevant Lines: 19498

💛 - Coveralls

@joshgummersall
Copy link
Contributor Author

Any repo that is "downstream" of botbuilder-dotnet can copy our template here and augment the workflow file to trigger.

@joshgummersall
Copy link
Contributor Author

@stevengum my goal was to use the simplest primitives possible in the bb-js repo and rely on upstream producers to determine when to trigger this action. Specifically, we could adjust the PR merge workflow in the botbuilder-dotnet to filter certain files via globs, or the like. This is basically an API endpoint for other things to use when they think we ought to have a new parity issue opened. I could possibly even adjust it to accept a title, description, and ref instead of being pull request specific to support issues as well.

joshgummersall added a commit to microsoft/botbuilder-dotnet that referenced this pull request Nov 20, 2020
This will remotely trigger the workflow introduced via
microsoft/botbuilder-js#3080
This workflow will create a parity issue that includes a short summary
and a link to a pull request, along with the parity label, to keep us
honest!

It will trigger on manual dispatch - actions will need to be added to
other repos to trigger this workflow.
steps:
- uses: actions/checkout@v2

- uses: joshgummersall/create-issue@main
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabog this action might be useful in writing a workflow to automatically create child issues from a parent botframework-sdk issue.

mrivera-ms pushed a commit to microsoft/botbuilder-dotnet that referenced this pull request Dec 1, 2020
This will remotely trigger the workflow introduced via
microsoft/botbuilder-js#3080
@joshgummersall joshgummersall merged commit 07e3266 into main Dec 1, 2020
@joshgummersall joshgummersall deleted the jpg/parity-workflow branch December 1, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants