Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: minify adaptive-expressions-ie11 #3068

Merged
merged 2 commits into from
Nov 23, 2020
Merged

feat: minify adaptive-expressions-ie11 #3068

merged 2 commits into from
Nov 23, 2020

Conversation

stevengum
Copy link
Member

@stevengum stevengum commented Nov 17, 2020 •
edited
Loading

Part 1 of #3053

Specific Changes

  • add terser-webpack-plugin@^4.2.3 to adaptive-expressions-ie11 (395b864)
    • new dist/ footprint:
      image

Additional context:

https://bundlephobia.com/[email protected]
https://bundlephobia.com/[email protected]

@coveralls
Copy link

coveralls commented Nov 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 379666386

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 84.759%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 4 60.76%
Totals Coverage Status
Change from base Build 375872031: -0.03%
Covered Lines: 17344
Relevant Lines: 19537
💛 - Coveralls

@joshgummersall
Copy link
Contributor

We want to minify the ie11 and non-ie11 browser bundles, right? I tried to set this up with browserify without much joy.

@stevengum stevengum marked this pull request as ready for review November 23, 2020 19:56
@stevengum stevengum requested a review from a team as a code owner November 23, 2020 19:56
@stevengum stevengum changed the title [WIP] minify adaptive-expressions libraries feat: minify adaptive-expressions-ie11 Nov 23, 2020
@stevengum
Copy link
Member Author

@joshgummersall that's correct, the goal is to do both 👍🏼

I decided it would be better to get this PR in and I'll revisit adaptive-expressions in another PR.

I want to avoid this PR sitting in our queue, and as you alluded to, a-e uses browserify so there's a different path to be investigated for a-e.

@stevengum stevengum merged commit 09e4b7f into main Nov 23, 2020
@stevengum stevengum deleted the stgum/3053 branch November 23, 2020 23:01
@stevengum stevengum mentioned this pull request Nov 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengum @coveralls @joshgummersall