fix: consistent user-agent handling #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgummersall
requested review from
carlosscastro,
johnataylor and
Stevenic
as code owners
joshgummersall
force-pushed
the
jpg/fix-bb-user-agent
branch
from
dfedc88 to
1c5b0b3
Compare
Co-authored-by: Steven Gum <[email protected]>
joshgummersall
commented
Nov 12, 2020
| @@ -1461,11 +1460,6 @@ export class BotFrameworkAdapter | |||
| return client; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Note: docs for private methods are not required.
| }); | ||
|
|
||
| // Resolve any user request policy factories, then includes our user agent via a factory policy | ||
| options.requestPolicyFactories = (defaultRequestPolicyFactories) => { |
There was a problem hiding this comment.
This is some convoluted logic to handle all the edge cases in the tests while simply enabling the disabled test. The order of policies is important as the userAgentPolicy handler will not override an existing use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2082