fix: use parameters.isGroup instead of false
#3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgummersall
requested review from
carlosscastro,
johnataylor,
stevengum and
Stevenic
as code owners
joshgummersall
force-pushed
the
jpg/fix-create-conversation-is-group-param-handling
branch
from
ae38f87 to
d5806ee
Compare
stevengum
requested changes
Nov 12, 2020
joshgummersall
force-pushed
the
jpg/fix-create-conversation-is-group-param-handling
branch
from
1073bac to
b33a1ee
Compare
joshgummersall
commented
Nov 12, 2020
This should support creating group conversations for channels that support it. Fixes #1124
joshgummersall
force-pushed
the
jpg/fix-create-conversation-is-group-param-handling
branch
from
b33a1ee to
66fd99f
Compare
Pull Request Test Coverage Report for Build 367178866
💛 - Coveralls |
joshgummersall
deleted the
jpg/fix-create-conversation-is-group-param-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should support creating group conversations for channels that
support it.
Fixes #1124
This also refactors the
createConversationoverload style to list discrete overloads for better documentation. See the following screenshots for how the overloads/JSDoc are interpreted in VSCode:All the remaining changes are a result of code formatting.