monorepo: ci, lint, package.json overhaul #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgummersall
requested review from
axelsrz,
carlosscastro,
EricDahlvang,
gabog,
garypretty,
johnataylor,
munozemilio,
stevengum,
Stevenic,
tomlm and
a team
as code owners
joshgummersall
force-pushed
the
jpg/gh-ci-lint-overhaul
branch
12 times, most recently
from
3a8d46c to
ea6db11
Compare
- restructure eslint configuration for better isolation - hoist many package.json script deps to root package.json - fix all `clean` scripts
Cleans up workflows and runs on Windows as well
joshgummersall
force-pushed
the
jpg/gh-ci-lint-overhaul
branch
4 times, most recently
from
eb37284 to
51a3fe0
Compare
Use spawn isntead of exec to get around buffering issues and make code less branchy. Add --scriptArgs flag to pass extra flags directly to an npm script. An unfortunately hacky way to support passing `--quiet` to eslint for CI.
joshgummersall
force-pushed
the
jpg/gh-ci-lint-overhaul
branch
7 times, most recently
from
a91905e to
cd88525
Compare
joshgummersall
commented
Nov 12, 2020
| }; | ||
| }, {}); | ||
|
|
||
| return new Promise((resolve, reject) => async.auto(tasks, concurrency, (err) => (err ? reject(err) : resolve()))); |
There was a problem hiding this comment.
async.auto is designed for exactly this problem.
The main reason I removed my old implementation is that it suffered from "head-of-line blocking". In particular, tasks were executed concurrently in groups. As a consequence, the slowest task in a group determines how long it takes to execute the group of tasks.
async.auto ensures that, if possible, N tasks are always being executed, where N = concurrency. The slight downside is that the async library generally does not play well with Promises or async/await.
Also uses async.auto rather than custom dependency resolution code
joshgummersall
force-pushed
the
jpg/gh-ci-lint-overhaul
branch
from
cd88525 to
c173859
Compare
stevengum
reviewed
Nov 12, 2020
stevengum
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a variety of open issues and some other tooling/monorepo clean up tasks.
Fixes #2415
Fixes #2416
Fixes #2417
Fixes #2418
Fixes #2419
Fixes #2420
Fixes #2421
Fixes #2422
Fixes #2423
Fixes #2424
Fixes #2425
Fixes #2426
Fixes #2428