Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tests for repo utils #3056

Merged
merged 1 commit into from
Nov 11, 2020
Merged

fix: add tests for repo utils #3056

merged 1 commit into from
Nov 11, 2020

Conversation

joshgummersall
Copy link
Contributor

Fixes #3047

@joshgummersall joshgummersall requested a review from a team as a code owner November 11, 2020 20:05
@joshgummersall joshgummersall force-pushed the jpg/repo-utils-tests branch 3 times, most recently from 1206bd8 to d43acf4 Compare November 11, 2020 20:27
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for adding this!

I especially like the new workflow using ubuntu and windows images. 😄

Do you want to add glob patterns to trigger the workflow on delta to:
.github/workflows/run-test-repoutils.yml
libraries/botbuilder-repo-utils/**

Or is it better that this run on every push and PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing: add unit testing for repo utils
2 participants