Adaptive TestRunner refactoring #3055
Conversation
| adapter.use(middleware); | ||
| }); | ||
|
|
||
| adapter.onTurnError = async (context, err) => { |
There was a problem hiding this comment.
This is a nit of mine, but this could more succinctly be written as adapter.onTurnError = (context, err) => context.sendActivity(err.message). No need to explicitly mark as async or await the result.
There was a problem hiding this comment.
Thx, I tried this but the return type of onTurnError is Promise<void> and the return type of context.sendActivity(err.message) is Promise<ResourceResponse>, how can I fix the mismatch issue?
|
|
||
| for (let i = 0; i < this.script.length; i++) { | ||
| const testAction = this.script[i]; | ||
| await testAction.execute(testAdapter, bot.onTurn.bind(bot)); | ||
| await testAction.execute(adapter, callback); |
There was a problem hiding this comment.
I'd rewrite this block to:
await Promise.all(this.script.map(testAction => testAction.execute(adapter, callback)));I wonder if it would also be useful to use something like p-map and a configurable concurrency to control concurrent execution. What do you think?
There was a problem hiding this comment.
Is there a way to execute all the scripts in order?
Fixes #2959
Description
Refactored TestRunner.
Specific Changes
TestRunnertoTestUtilsto match naming in C#TestUtilsrunTestScriptstaticrunTestScriptTesting
Updated existing tests.