Cached lgm initialization in lg extension #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2020
libraries/botbuilder-dialogs-adaptive/src/languageGeneratorExtensions.ts
Outdated
Show resolved
Hide resolved
joshgummersall
approved these changes
Nov 2, 2020
libraries/botbuilder-dialogs-adaptive/src/languageGeneratorExtensions.ts
Outdated
Show resolved
Hide resolved
|
@joshgummersall Caching lgm in a map may cause GC issues, check out this issue: microsoft/botbuilder-dotnet#4871 |
|
I think a Weakmap would work for this use case as long as all the targets for this library support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2988
Description
Cached instances of
LanguageGeneratorManagerinLanguageGeneratorExtensionsto avoid registering duplicated callbacks in resource explorer.Specific Changes
Testing