Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: browserify build/test flakes #2957

Merged
merged 3 commits into from
Oct 27, 2020
Merged

fix: browserify build/test flakes #2957

merged 3 commits into from
Oct 27, 2020

Conversation

joshgummersall
Copy link
Contributor

  • Clear out browser-related files in bf-connector (cause of dotjs test flakes)
  • More consistent use of "browser" setting, exorcist, etc.

cc @BruceHaley

@joshgummersall joshgummersall changed the title Clean up browserify use fix: browserify build/test flakes Oct 26, 2020
Clean up browserify use
c82bfee 
- Clear out browser-related files in bf-connector (cause of dotjs
test flakes)
- More consistent use of "browser" setting, exorcist, etc.
@joshgummersall joshgummersall force-pushed the jpg/fix-browserify-flakes branch from f36fe58 to c82bfee Compare October 27, 2020 15:10
stevengum
stevengum approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are we going to need this in 4.11?

@joshgummersall
Copy link
Contributor Author

@stevengum I don't think so - the only "observable" difference to consumers should be the adaptive-expressions "browser" setting. I don't think they use or care about that, though. If we cut another 4.11.x release, I suppose we should include this, but I wouldn't block the RCs for it.

@joshgummersall joshgummersall merged commit 6c8d798 into main Oct 27, 2020
@joshgummersall joshgummersall deleted the jpg/fix-browserify-flakes branch October 27, 2020 19:33
joshgummersall added a commit that referenced this pull request Oct 27, 2020
@joshgummersall
Clean up browserify use (#2957)
37287b0 
- Clear out browser-related files in bf-connector (cause of dotjs
test flakes)
- More consistent use of "browser" setting, exorcist, etc.
joshgummersall added a commit that referenced this pull request Oct 27, 2020
@joshgummersall
Clean up browserify use (#2957) (#2961)
2a845d8 
- Clear out browser-related files in bf-connector (cause of dotjs
test flakes)
- More consistent use of "browser" setting, exorcist, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshgummersall @stevengum