This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[PORT]Throw exception when circular reference is detected in LG imports #2913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshgummersall
left a comment
joshgummersall
left a comment
There was a problem hiding this comment.
I left a few inline suggestions. Otherwise, this looks good!
joshgummersall
approved these changes
Oct 20, 2020
Contributor
joshgummersall
left a comment
joshgummersall
left a comment
There was a problem hiding this comment.
Nice! Looks good to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2340
Original PR:microsoft/botbuilder-dotnet#4779
Description
Having two language generation files that import each other causes an infinite loop.
Specific Changes
Throw exception when occurs the cycle reference in LG import.
For example: there are two Lg files:
a.lg
and b.lg
When parsing the a.lg, using
Templates.ParseFile("a.lg"), would get a "loop detect exception."