Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track unhandled events in dialog container #2645

Merged
merged 5 commits into from
Aug 7, 2020
Merged

Track unhandled events in dialog container #2645

merged 5 commits into from
Aug 7, 2020
+33 −21

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Aug 5, 2020 •
edited
Loading

Fixes #2529

Description

Send a trace activity and log a trace event via the telemetry client for 'versionChanged' dialog events.
.NET PR microsoft/botbuilder-dotnet#4270

Specific Changes

  • Implemented onDialogEvent in DialogContainer to track unhandled dialog events.

Testing

@chon219 chon219 requested a review from a team as a code owner August 5, 2020 02:49
@chon219 chon219 self-assigned this Aug 5, 2020
@chon219 chon219 requested a review from stevengum August 5, 2020 02:49
@coveralls
Copy link

coveralls commented Aug 5, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 155041

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 83.003%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/builtinFunctions/getNextViableTime.ts 1 88.89%
libraries/adaptive-expressions/src/builtinFunctions/getPreviousViableTime.ts 1 87.3%
Totals Coverage Status
Change from base Build 155036: 0.06%
Covered Lines: 15011
Relevant Lines: 17193
💛 - Coveralls

stevengum
stevengum requested changes Aug 5, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chon219 can you add appropriate unit tests for this?

@chon219 chon219 requested a review from stevengum August 7, 2020 03:17
@chon219 chon219 merged commit 5ccc40f into master Aug 7, 2020
@chon219 chon219 deleted the zim/track-unhandled-events branch August 7, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees

@chon219 chon219

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track key unhandled DialogEvents in telemetry
3 participants
@chon219 @coveralls @stevengum