[Engineering] Lower time for botbuilder-dialogs-adaptive-testing tests #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengum
approved these changes
Jul 31, 2020
denscollo
deleted the
southworks/update/botbuilder-dialogs-adaptive-testing-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2338
Description
Removed a duplicated test in the BotBuilder-dialogs-adaptive-testing tests.
Specific Changes
Removed duplicated test
EmitEventActivityReceivedin the fileadaptiveDialog.test.jsand added missing end of file line.Testing
This change does not reduce code coverage.
As you can see the time would be reduced approximately 15ms, which is the time that was taking the duplicated test.
