Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SpeechConstants and tests for CallerIdConstants #2597

Merged
merged 1 commit into from
Jul 28, 2020
Merged

add SpeechConstants and tests for CallerIdConstants #2597

merged 1 commit into from
Jul 28, 2020

Conversation

stevengum
Copy link
Member

Fixes #2558 (parity with microsoft/botbuilder-dotnet#4319)

Specific Changes

  • Adds SpeechConstants.EmptySpeakTag
  • Adds tests for SpeechConstants and CallerIdConstants where these classes' static values are defined per the Bot Framework Activity specification.

@coveralls
Copy link

coveralls commented Jul 28, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 150819

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 82.63%
Totals Coverage Status
Change from base Build 150786: 0.07%
Covered Lines: 14567
Relevant Lines: 16798
💛 - Coveralls

johnataylor
johnataylor approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@johnataylor johnataylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃

@stevengum stevengum merged commit eff5b22 into master Jul 28, 2020
@stevengum stevengum deleted the stgum/2558 branch July 28, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnataylor johnataylor johnataylor approved these changes

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a constant for "empty speak tag"
3 participants
@stevengum @coveralls @johnataylor