Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update botbuilder-dialogs-declarative README #2575

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Update botbuilder-dialogs-declarative README #2575

merged 2 commits into from
Jul 24, 2020

Conversation

stevengum
Copy link
Member

Description

Indicate on README for botbuilder-dialogs-declarative that it is a preview library and only works for Node.js v10, v12.

The following line is derived from the description of Microsoft.Bot.Builder.Dialogs.Declarative:

"This preview library implements Node.js support Declarative definition of dialogs assets."

@JonathanFingold, @Kaiqb FYI

@stevengum stevengum requested a review from a team as a code owner July 24, 2020 18:18
@coveralls
Copy link

coveralls commented Jul 24, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 149886

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 81.551%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 149867: -0.07%
Covered Lines: 13430
Relevant Lines: 15702
💛 - Coveralls

@stevengum stevengum merged commit 54011eb into master Jul 24, 2020
@stevengum stevengum deleted the stgum/declarative branch July 24, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwacsena vishwacsena vishwacsena approved these changes

@sgellock sgellock Awaiting requested review from sgellock

@chrimc62 chrimc62 Awaiting requested review from chrimc62

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengum @coveralls @vishwacsena