Restore and activate nock #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrichardson
requested review from
axelsrz,
carlosscastro and
johnataylor
as code owners
Closed
Pull Request Test Coverage Report for Build 149212
💛 - Coveralls |
stevengum
approved these changes
Jul 23, 2020
This was referenced Aug 5, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2563
Core issue is that the
-connectormetadata tests break after runningnpm run testmultiple times. This is band-aid fix that addresses the symptom but not the real problem, which I believe is nock cross-pollution between tests. Tracking that in the issue above to fix tomorrow.Edit post-merge:
After more digging, it seems less like a
nock.restore()issue and more like a multiple-nock-instances concurrency issue.