-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up emulator check in Cosmos Test #2547
Conversation
Pull Request Test Coverage Report for Build 148355
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to perform a cleanup before we do the constructor tests?
@stevengum I wouldn't say that it's strictly necessary. Because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking as @mdrichardson are iterating on this right now.
…icrosoft/botbuilder-js into mdrichardson/cosmosEmulatorFix
Description
Cosmos tests would throw errors in prep and cleanup scripts if both:
Specific Changes
The Emulator check now only tries a GET request at the Emulator endpoint. If there is no response, it skips the prep and cleanup steps that would require emulator.