Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up emulator check in Cosmos Test #2547

Merged
merged 10 commits into from
Jul 21, 2020
Merged

Conversation

mdrichardson
Copy link
Contributor

Description

Cosmos tests would throw errors in prep and cleanup scripts if both:

  1. Cosmos Emulator installed at appropriate path
  2. Cosmos Emulator was not running

Specific Changes

The Emulator check now only tries a GET request at the Emulator endpoint. If there is no response, it skips the prep and cleanup steps that would require emulator.

@coveralls
Copy link

coveralls commented Jul 17, 2020

Pull Request Test Coverage Report for Build 148355

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 81.452%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 147758: -0.07%
Covered Lines: 13344
Relevant Lines: 15628

💛 - Coveralls

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdrichardson
Copy link
Contributor Author

@stevengum I wouldn't say that it's strictly necessary. Because cleanup erases all DBs and it isn't called until after in the "Base Storage Tests" section, there's a small chance that an existing DB could interfere with those tests.

Michael Richardson added 3 commits July 20, 2020 16:34
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking as @mdrichardson are iterating on this right now.

@stevengum stevengum merged commit 0480b9d into master Jul 21, 2020
@stevengum stevengum deleted the mdrichardson/cosmosEmulatorFix branch July 21, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants