Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Teams] Fix onSelectedItem in Teams Search Extension Bot #2544

Merged
merged 4 commits into from
Jul 17, 2020
Merged

[Teams] Fix onSelectedItem in Teams Search Extension Bot #2544

merged 4 commits into from
Jul 17, 2020

Conversation

denscollo
Copy link
Contributor

@denscollo denscollo commented Jul 16, 2020 •
edited
Loading

Addresses #1314

Description

This PR fixes how the teamsSearchExtensionBot handles the onSelectedItem event so it returns a hero card for every result selected by the user.

Detailed changes

Testing

The images below show the bot running on Teams.

image

@denscollo denscollo requested a review from a team as a code owner July 16, 2020 20:50
@denscollo denscollo requested a review from stevengum July 16, 2020 20:50
@mrivera-ms mrivera-ms requested a review from EricDahlvang July 17, 2020 18:06
stevengum
stevengum approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting for @EricDahlvang to verify

EricDahlvang
EricDahlvang approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these samples are being moved to the samples repo in R10, so no further work on them is needed.

But we will take this PR, thanks.

@EricDahlvang EricDahlvang merged commit 916728e into microsoft:master Jul 17, 2020
@ceciliaavila ceciliaavila deleted the southworks/fix/search-based-messaging-extension-bot branch July 17, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@EricDahlvang EricDahlvang EricDahlvang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denscollo @EricDahlvang @stevengum @ceciliaavila