Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patch] SSO + Teams: Maintain sign-in link for Teams OAuth #2520

Merged
merged 2 commits into from
Jul 13, 2020
Merged

[Patch] SSO + Teams: Maintain sign-in link for Teams OAuth #2520

merged 2 commits into from
Jul 13, 2020

Conversation

carlosscastro
Copy link
Member

No description provided.

@carlosscastro carlosscastro changed the title SSO + Teams: Maintain sign-in link for Teams OAuth [Patch] SSO + Teams: Maintain sign-in link for Teams OAuth Jul 13, 2020
@coveralls
Copy link

coveralls commented Jul 13, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 145927

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 80.212%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs/src/prompts/oauthPrompt.ts 3 4 75.0%
Totals Coverage Status
Change from base Build 145878: -0.006%
Covered Lines: 12650
Relevant Lines: 15054
💛 - Coveralls

@cleemullins cleemullins merged commit b72ac29 into 4.9 Jul 13, 2020
@cleemullins cleemullins deleted the ccastro/sso-teams-adjustments branch July 13, 2020 22:20
carlosscastro added a commit that referenced this pull request Jul 27, 2020
@carlosscastro
SSO + Teams: Maintain sign-in link for Teams OAuth (#2520)
9991bf3
stevengum pushed a commit that referenced this pull request Jul 28, 2020
@carlosscastro
SSO + Teams cherry pick from 4.9 (#2589)
1908c68 
* Teams + SSO: Update OAuthcard channel support and return 412 instead of 409 on sso fail (#2407)

* Teams + SSO: Update OAuthcard channel support and return 412 instead of 409 on sso fail

* SSO: Update OAuthPrompt test to match new status code

* SSO + Teams: Maintain sign-in link for Teams OAuth (#2520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosscastro @coveralls @cleemullins