Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kyled/async functions #2506

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Kyled/async functions #2506

merged 2 commits into from
Jul 28, 2020

Conversation

v-kydela
Copy link
Contributor

@v-kydela v-kydela commented Jul 8, 2020

Followup to #2476 at @stevengum's request

@coveralls
Copy link

coveralls commented Jul 9, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 144686

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.692%
Totals Coverage Status
Change from base Build 144601: 0.0%
Covered Lines: 12990
Relevant Lines: 15377
💛 - Coveralls

stevengum
stevengum approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum stevengum merged commit 8a06762 into master Jul 28, 2020
@stevengum stevengum deleted the kyled/asyncFunctions branch July 28, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@gurvsing gurvsing Awaiting requested review from gurvsing

@munozemilio munozemilio Awaiting requested review from munozemilio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-kydela @coveralls @stevengum