[PORT] Add LG telemetry

[Danieladu]

Fixes #1864

Add LG telemetry

[coveralls]

Pull Request Test Coverage Report for Build 154271

• 12 of 13 (92.31%) changed or added relevant lines in 5 files are covered.
• 2 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.1%) to 82.811%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
libraries/botbuilder-dialogs-adaptive/src/input/inputDialog.ts	6	7	85.71%

Files with Coverage Reduction	New Missed Lines	%
libraries/botbuilder-dialogs-adaptive/src/actions/beginSkill.ts	1	64.1%
libraries/botbuilder-dialogs-adaptive/src/input/inputDialog.ts	1	78.08%

Totals
Change from base Build 154236:	0.1%
Covered Lines:	14737
Relevant Lines:	16916

---

💛 - Coveralls

[chrimc62]

🕐

[stevengum]

Thanks for the changes @Danieladu. Can you add some unit tests for them?

@tomlm these telemetry client calls in BeginSkill and HttpRequest don't exist in the .NET implementation. Can you review this PR and determine if we want to port them over to .NET?

HttpRequest.ReplaceJTokenRecursivelyAsync()
BeginSkill.BeginDialogAsync()

[stevengum]

@chrimc62, should the telemetryClient calls in BeginSkill and HttpRequest be ported back to C#?

[chrimc62]

Yes if they are here only.

---

In reply to: 655837544 [](ancestors = 655837544)

[chrimc62]

[stevengum]

@Danieladu unit tests? 🕐

[Danieladu]

@Danieladu unit tests? 🕐

Sorry for the delay. i hope I can add some unit tests in the next few days.
BTW, I found there is still no unit test for C# side for all telemetry, and test the telemetry is very hard because it is just a small part of the dialog flow evaluation. So, could you give some advices that how to test the telemetry? Hmmm, currently, I have no idea about this part.

[boydc2014]

@Danieladu unit tests? 🕐

Sorry for the delay. i hope I can add some unit tests in the next few days.
BTW, I found there is still no unit test for C# side for all telemetry, and test the telemetry is very hard because it is just a small part of the dialog flow evaluation. So, could you give some advices that how to test the telemetry? Hmmm, currently, I have no idea about this part.

maybe mock a telemetry client and assert the mock client is been called with expected data?

out of date

[stevengum]

Please see feedback for guidance on authoring tests along with examples.

[stevengum]

Since a Dialog will automatically have at least a NullTelemetryClient, you can use sinon to stub out the trackEvent method on dialogInstance.telemetryClient.

const { stub } = require('sinon');
const trackEventStub = stub(mockDialog.telemetryClient, 'trackEvent');

// Later after the method that calls trackEvent finishes
assert(trackEventStub.called);

And use a captureAction to verify the stub's input.

There are also examples in botframeworkAdapter.test.js and the skillDialog.test.js files. The SkillDialog tests may be more helpful and will show an example closer to what @boydc2014 suggested. Additionally, the tests for SkillDialog in JS are extremely close to the tests in .NET (see SkillDialogTests.cs), so that may help in authoring tests for the LG Telemetry changes.

[Danieladu]

I have added some telemetry tests in skillDialog.test.js. Please take a look. Thanks.

[stevengum]

@Danieladu the updates to the BeginSkill tests looks great, can you move createTelemetryClientAndStub() to a utilities file since that capture action is self contained and then use it for the other tests as well?

[stevengum]

Can you make the function name pascal cased? createTelemetryClientAndStub

[stevengum]

The test changes look good so far, per my comment can you apply do some small refactoring to reuse the test logic to add tests for the other changes in this PR?