Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unionize TaskModuleResponse.task type definition #2446

Merged
merged 5 commits into from
Jul 1, 2020

Conversation

EricDahlvang
Copy link
Member

Fixes #1588

@EricDahlvang EricDahlvang requested a review from benbrown June 29, 2020 22:06
@EricDahlvang EricDahlvang requested a review from a team as a code owner June 29, 2020 22:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 141977

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 80.961%

Totals Coverage Status
Change from base Build 141906: 0.07%
Covered Lines: 12915
Relevant Lines: 15236

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 29, 2020

Pull Request Test Coverage Report for Build 142928

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.033%

Totals Coverage Status
Change from base Build 142911: 0.0%
Covered Lines: 12985
Relevant Lines: 15307

💛 - Coveralls

@EricDahlvang
Copy link
Member Author

Hold merging this... @stevengum pointed out another place we should use this same union

@stevengum
Copy link
Member

@EricDahlvang and I still want to take this PR with the additional changes he mentioned.

Pedantically speaking, this is PR is a breaking change. However, Teams will not respect TaskModuleResponseBases that aren't one of the subtypes: TaskModuleContinueResponse | TaskModuleMessageResponse, so sending anything else will result in an error.

@stevengum stevengum closed this Jul 1, 2020
@stevengum stevengum reopened this Jul 1, 2020
@EricDahlvang EricDahlvang merged commit e389d6f into master Jul 1, 2020
@EricDahlvang EricDahlvang deleted the eric/updateTaskModuleResponse branch July 1, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TaskModuleResponseBase interface definition does not support additional necessary fields
4 participants