Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and un-skip getTokenStatus test #2414

Merged
merged 11 commits into from
Jul 28, 2020
Merged

fix and un-skip getTokenStatus test #2414

merged 11 commits into from
Jul 28, 2020

Conversation

mdrichardson
Copy link
Contributor

@mdrichardson mdrichardson commented Jun 24, 2020 •
edited
Loading

Fixes #1449

Description

getTokenStatus test in BotFrameworkAdapter was skipped/disabled because it was broken. This fixes it by mocking the response and re-enables the test.

@mdrichardson mdrichardson requested a review from a team as a code owner June 24, 2020 21:57
@coveralls
Copy link

coveralls commented Jun 24, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 151277

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.95%
Totals Coverage Status
Change from base Build 151234: 0.0%
Covered Lines: 14557
Relevant Lines: 16888
💛 - Coveralls

@stevengum stevengum merged commit 4ab6ae7 into master Jul 28, 2020
@stevengum stevengum deleted the mdrichardson/fixADALtest branch July 28, 2020 23:45
@mdrichardson mdrichardson mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

@johnataylor johnataylor Awaiting requested review from johnataylor

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tests] Fix BotFrameworkAdapter.getTokenStatus() test
3 participants
@mdrichardson @coveralls @stevengum