Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme from docs pillar review #2408

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

garypretty
Copy link
Contributor

Fixes #2403 (part of SDK tracking issue microsoft/botframework-sdk#5898)

Updates the readme in line with previous updates to .NET / Python readmes, following the docs pillar review. Brings standardization to readmes, adds missing packages and also brings in the content regarding building the SDK in from the wiki (which will be removed following the merge of this PR).

@garypretty garypretty requested a review from a team as a code owner June 24, 2020 11:21
@garypretty garypretty requested review from Stevenic and stevengum June 24, 2020 11:21
@coveralls
Copy link

coveralls commented Jun 24, 2020

Pull Request Test Coverage Report for Build 140696

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.888%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 140212: -0.07%
Covered Lines: 12906
Relevant Lines: 15236

💛 - Coveralls

@stevengum stevengum merged commit 63e9651 into master Jun 24, 2020
@stevengum stevengum deleted the gary/readme-update branch June 24, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] Updates to readme
3 participants