-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated OAuthInput to be on parity with dotnet sdk #2349
Conversation
Pull Request Test Coverage Report for Build 143845
💛 - Coveralls |
We may need to test OAuthInput E2E to make sure it will work as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this PR e2e and found that the OAuthInput doesn't work as expected in skill mode. I think we need to port the updates from this commit, 1a2a64a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test e2e for both bot mode and skill mode, both work well.
Fixes #2034
Fixes #2152
Fixes #2396
Description
Updated OAuthInput to be on parity with dotnet sdk.
Specific Changes
Testing
We don't have unit tests for OAuthInput in both c# and js sdk, we may need to test it e2e to make sure everything work as expected.