Removed fallback exception from version change logic. #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleemullins
changed the title
Pull Request Test Coverage Report for Build 134399
💛 - Coveralls |
stevengum
approved these changes
May 28, 2020
cleemullins
approved these changes
Jun 1, 2020
|
The C# PR that matches this is here: |
mrivera-ms
pushed a commit
that referenced
this pull request
Jun 2, 2020
* Removed fallback exception from version cgange logic. * Removed un-needed unit test * Removed console log Co-authored-by: Steven Gum <[email protected]>
stevengum
added a commit
that referenced
this pull request
Jun 2, 2020
* Removed fallback exception from version cgange logic. * Removed un-needed unit test * Removed console log Co-authored-by: Steven Gum <[email protected]> Co-authored-by: Steven Ickman <[email protected]> Co-authored-by: Steven Gum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added a new feature in 4.9 to automatically detect dialog changes. Some customers are complaining about the fallback logic we have to automatically throw an exception if the bot doesn't handle the new event we added. We've decided to remove the fallback exception and make the feature entirely opt-in.