Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LowScoreVariation and add return types [PORT] #2266

Merged
merged 4 commits into from
Jun 30, 2020
Merged

Fix LowScoreVariation and add return types [PORT] #2266

merged 4 commits into from
Jun 30, 2020

Conversation

mrestorff
Copy link
Contributor

Fixes #2017

Description

Ported the changes from C#. Added return types to functions, also according to C# version. Also fixed the improper syntax of the TS/JSDoc comments for the variables.

Specific Changes

  • add return types to getLowScoreVariation() and includeForClustering()
  • for first item with score more than MaxScoreForLowScoreVariation return the list with first item
  • use let instead of var
  • fix TSDoc comments

@tracyboehrer tracyboehrer requested a review from a team as a code owner June 30, 2020 20:47
@stevengum stevengum merged commit bb60511 into microsoft:master Jun 30, 2020
@mrestorff mrestorff deleted the qna-lowscorevariation branch July 2, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgellock sgellock sgellock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] [LowScoreVariation]For first item with score more than MaxScoreForLow…
5 participants
@mrestorff @sgellock @stevengum @Danieladu @tracyboehrer