Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing break/return statements. #2240

Merged
merged 1 commit into from
May 15, 2020
Merged

Missing break/return statements. #2240

merged 1 commit into from
May 15, 2020

Conversation

Stevenic
Copy link
Contributor

Fixes #2222

Description

The teams handler had a switch statement that was falling through.

@Stevenic Stevenic requested review from johnataylor and stevengum May 14, 2020 22:30
@coveralls
Copy link

coveralls commented May 14, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 131165

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 80.263%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/teamsActivityHandler.ts 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder/src/teamsActivityHandler.ts 1 73.68%
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 131081: -0.08%
Covered Lines: 12684
Relevant Lines: 15087
💛 - Coveralls

@stevengum stevengum merged commit cfca711 into master May 15, 2020
@stevengum stevengum deleted the stevenic/teams-handler-fix branch May 15, 2020 00:54
stevengum pushed a commit that referenced this pull request May 15, 2020
@Stevenic @stevengum
Missing break/return statements. (#2240)
6b8a230
Stevenic added a commit that referenced this pull request May 15, 2020
@stevengum @Stevenic
Missing break/return statements. (#2240) (#2242)
325219b 
Co-authored-by: Steven Ickman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@johnataylor johnataylor Awaiting requested review from johnataylor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shouldn't we should use return statement here?
3 participants
@Stevenic @coveralls @stevengum