-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive dialogs bug fix #2201
Adaptive dialogs bug fix #2201
Conversation
Pull Request Test Coverage Report for Build 136129
💛 - Coveralls |
@chon219, This is an R10 fix, and with R10 we're starting a new policy. PRs need to have an issue. Can you please create an issue, tag & triage it appropiatly, and then tie it to this PR? |
WE'll be enabling the github enforcement of this soon, but we should start now. |
OK, I'll create related issues later. Thanks for reminding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit test coverage for these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change for the OAuthInput, but there are some other concerns I have regarding the use of Entity in the RegexRecognizer. (And add unit tests)
libraries/botbuilder-dialogs-adaptive/src/recognizers/regexRecognizer.ts
Show resolved
Hide resolved
Dismissing as unit tests were added to PR
Fixes: #2210
Fixes: #2209
Description
We found some minor bugs in adaptive dialogs and we need fix them in this PR.
Specific Changes