Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added expression binding logic #2172

Merged
merged 1 commit into from
May 4, 2020

Conversation

Stevenic
Copy link
Contributor

@Stevenic Stevenic commented May 4, 2020

Fixes #1818

Description

Class memory scope wasn't expanding expressions properties.

Specific Changes

  • Added logic to expand expression properties.
  • Added missing DialogClassMemoryScope.
  • Fixed case for scope enums and added doc comments.

Testing

Updated unit tests to test property expansion.

Also added new DialogClassMemoryScope.
@Stevenic Stevenic requested review from stevengum and tomlm May 4, 2020 19:51
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some misgivings about the name *ClassMemoryScope, but it otherwise looks fine... Tests would be nice 😄

@coveralls
Copy link

coveralls commented May 4, 2020

Pull Request Test Coverage Report for Build 127935

  • 30 of 39 (76.92%) changed or added relevant lines in 6 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 79.848%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs/src/memory/scopes/dialogClassMemoryScope.ts 5 14 35.71%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 127853: -0.1%
Covered Lines: 12462
Relevant Lines: 14891

💛 - Coveralls

@stevengum stevengum merged commit 88fad0e into master May 4, 2020
@stevengum stevengum deleted the stevenic/expression-property-binding branch May 4, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] fix memory scope for class memory scope to evaluate expressionProperties
4 participants