Update SkillDialog to handle all activity types (e.g. set DeliveryMode for Invokes)

[stevengum]

Fixes #2139

Specific Changes

• Add StatusCodes.MULTIPLE_CHOICES = 300
• Add protected method SkillDialog.onValidateActivity()
• SkillDialog now forwards all ActivityTypes to the Skill.
• Add new C# SkillDialog tests and refactor old tests
• Add missing test for TurnContext when deliveryMode === 'expectReplies'
• Fix error message in BotFrameworkAdapter.createConnectorClientWithIdentity()
• Add tests for BotFrameworkAdapter.createConnectorClientWithIdentity()
• Add test for BotFrameworkAdapter.processActivity() when deliveryMode === 'expectReplies', type is Invoke and reply activities have type invokeResponse

[coveralls]

Pull Request Test Coverage Report for Build 127831

• 39 of 43 (90.7%) changed or added relevant lines in 3 files are covered.
• 9 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.03%) to 79.897%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
libraries/botbuilder-dialogs/src/skillDialog.ts	32	36	88.89%

Files with Coverage Reduction	New Missed Lines	%
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts	2	80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts	7	66.67%

Totals
Change from base Build 127684:	0.03%
Covered Lines:	12444
Relevant Lines:	14864

---

💛 - Coveralls

[johnataylor]

having to switch expectReplies on for an invoke seems a little odd.

[gabog]

if the dialog is interacting with a skill that only works with invokes, this makes sure that EoC replies are buffered with the invokeResponse and the dialog ends when an EoC comes back.

Here is an example on how this would look on a skill for teams:

protected override async Task<TaskModuleResponse> OnTeamsTaskModuleSubmitAsync(ITurnContext<IInvokeActivity> turnContext, TaskModuleRequest taskModuleRequest, CancellationToken cancellationToken)
{
    var reply = MessageFactory.Text("OnTeamsTaskModuleSubmitAsync Value: " + JsonConvert.SerializeObject(taskModuleRequest));
    await turnContext.SendActivityAsync(reply, cancellationToken);
            
    // Send End of conversation at the end.
    var activity = new Activity(ActivityTypes.EndOfConversation) { Value = taskModuleRequest.Data, Locale = ((Activity)turnContext.Activity).Locale };
    await turnContext.SendActivityAsync(activity, cancellationToken);

    return new TaskModuleResponse
    {
        Task = new TaskModuleMessageResponse
        {
            Value = "Thanks!",
        },
    };
}

[johnataylor]

and this change presumably for consistency with the other place this condition occurs...

[stevengum]

Yes, these changes are ported from C# with exactly the same spirit (and tests) in mind. That said, I will add some more complex unit tests tomorrow to cover the interactions between the BFAdapter and ActivityHandler, and the two with SkillDialog.