Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed GovernmentConstants.ToChannelFromBotLoginUrl #2138

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Changed GovernmentConstants.ToChannelFromBotLoginUrl #2138

merged 2 commits into from
Apr 29, 2020

Conversation

mdrichardson
Copy link
Contributor

Fixes #2133

Description

Per @willportnoy, this is the only changed needed for now since, unlike the Dotnet repo, JS doesn't:

  • use GovernmentAppCredentials
  • write its own AdalAuthenticator

Changes

Changes GovernmentConstants.ToChannelFromBotLoginUrl to https://login.microsoftonline.us/MicrosoftServices.onmicrosoft.us

@coveralls
Copy link

coveralls commented Apr 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 126425

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 79.794%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 126375: -0.08%
Covered Lines: 12348
Relevant Lines: 14762
💛 - Coveralls

@cleemullins cleemullins merged commit c85e9fd into master Apr 29, 2020
@cleemullins cleemullins deleted the mdrichardson/govtConstant branch April 29, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

@stevengum stevengum Awaiting requested review from stevengum

@willportnoy willportnoy Awaiting requested review from willportnoy

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] [Authentication] updates to support Arlington
3 participants
@mdrichardson @coveralls @cleemullins