Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT][Expression] fix null check in expression #2118

Merged
merged 1 commit into from
Apr 28, 2020
Merged

[PORT][Expression] fix null check in expression #2118

merged 1 commit into from
Apr 28, 2020

Conversation

Danieladu
Copy link
Contributor

Fixes #2056

Fix checking null value in expression

@coveralls
Copy link

coveralls commented Apr 28, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 125596

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 79.794%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 125560: -0.07%
Covered Lines: 12348
Relevant Lines: 14762
💛 - Coveralls

@Danieladu Danieladu merged commit 18cb982 into master Apr 28, 2020
@Danieladu Danieladu deleted the hond/fix-expression-check branch April 28, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmicshuai cosmicshuai cosmicshuai approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] [LG] fix null check in expression
3 participants
@Danieladu @coveralls @cosmicshuai