Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add activity factory test #2095

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Add activity factory test #2095

merged 2 commits into from
Apr 24, 2020

Conversation

Danieladu
Copy link
Contributor

Add activity factory test

@coveralls
Copy link

coveralls commented Apr 24, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 124173

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.5%) to 79.062%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 123937: 1.5%
Covered Lines: 12209
Relevant Lines: 14722
💛 - Coveralls

@Danieladu Danieladu requested a review from cosmicshuai April 24, 2020 07:02
@Danieladu Danieladu merged commit 9de8525 into master Apr 24, 2020
@Danieladu Danieladu deleted the hond/add-activityfactory-test branch April 24, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmicshuai cosmicshuai cosmicshuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Danieladu @coveralls @cosmicshuai