Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom endpoint to LuisService #2072

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Add custom endpoint to LuisService #2072

merged 2 commits into from
Apr 22, 2020

Conversation

garypretty
Copy link
Contributor

Fixes #2064 - parity for C# implementation.

@garypretty garypretty requested review from Stevenic and tomlm April 21, 2020 10:09
@garypretty garypretty mentioned this pull request Apr 21, 2020
Closed
2 tasks
@coveralls
Copy link

coveralls commented Apr 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 123139

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 77.494%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-config/src/models/luisService.ts 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 123074: -0.08%
Covered Lines: 11935
Relevant Lines: 14677
💛 - Coveralls

@garypretty garypretty merged commit 38852ea into master Apr 22, 2020
@garypretty garypretty deleted the gary/luis-service-custom-endpoint branch April 22, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] Add custom endpoint property to the LuisService class
4 participants
@garypretty @coveralls @cleemullins @stevengum