Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] re-do multiLingualLg #2053

Merged
merged 6 commits into from
Apr 22, 2020
Merged

[PORT] re-do multiLingualLg #2053

merged 6 commits into from
Apr 22, 2020

Conversation

Danieladu
Copy link
Contributor

@Danieladu Danieladu commented Apr 17, 2020

ref: microsoft/botbuilder-dotnet#3551
close: #2084

  • add a defaultLanguages param format list which can replace "" as default
  • sync with latest SDK how language policy is updated, "de-de" => "de-de", "de"
  • replace EvaluateText with Evaluate
  • support passed in parsed Templates instead of just file paths, Dict<string, Templates>

@coveralls
Copy link

coveralls commented Apr 17, 2020

Pull Request Test Coverage Report for Build 123023

  • 1 of 26 (3.85%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 77.499%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-lg/src/multiLanguageLG.ts 1 26 3.85%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/multiLanguageLG.ts 1 2.74%
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 122999: -0.1%
Covered Lines: 11934
Relevant Lines: 14675

💛 - Coveralls

@Danieladu Danieladu changed the title [PORT] re-do multiLingualLg [WIP][PORT] re-do multiLingualLg Apr 20, 2020
@Danieladu Danieladu changed the title [WIP][PORT] re-do multiLingualLg [PORT] re-do multiLingualLg Apr 22, 2020
@Danieladu Danieladu merged commit c8129be into master Apr 22, 2020
@Danieladu Danieladu deleted the hond/multi-lang branch April 22, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] [LG] re-do multiLingualLg
3 participants