Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Adaptive] QnAMakerRecognizer and OnQnAMatch #2029

Merged
merged 9 commits into from
Apr 21, 2020
Merged

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Apr 15, 2020

Close #1695

Description

Ported QnAMakerRecognizer and OnQnAMatch from botbuilder-dotnet.

Specific Changes

  • Implemented QnAMakerRecognizer as one of recognizers
  • Implemented OnQnAMatch as one of trigger conditions
  • Refactored api of Recognizer class to follow the implementation in botbuilder-dotnet

Testing

All newly implemented components have tests covered.

@chon219 chon219 self-assigned this Apr 15, 2020
@coveralls
Copy link

coveralls commented Apr 15, 2020

Pull Request Test Coverage Report for Build 122086

  • 79 of 86 (91.86%) changed or added relevant lines in 18 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+9.5%) to 76.856%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/qnaMaker/qnaMakerRecognizer.ts 44 45 97.78%
libraries/botbuilder-dialogs-adaptive/src/input/oauthInput.ts 1 3 33.33%
libraries/botbuilder-dialogs-adaptive/src/conditions/onCondition.ts 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 122082: 9.5%
Covered Lines: 11757
Relevant Lines: 14560

💛 - Coveralls

@chon219 chon219 requested review from Stevenic and 035 and removed request for 035 April 16, 2020 02:25
Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Stevenic Stevenic merged commit 5be5118 into master Apr 21, 2020
@Stevenic Stevenic deleted the zim/qnamaker-recognizer branch April 21, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] QnAMakerRecognizer and OnQnAMatch classes
3 participants