Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] update adaptive inputs to set inputHint = expectingInput #2022

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

Danieladu
Copy link
Contributor

close: #1776
At first, LG ActivityFactory use MessageFactory.Text() to generate message activity result from LG output, but MessageFactory.Text() would inject inputhint = expectingInput into activity, and the prompt of input relies on this feature.

Then we found there is no reason to add inputhint into pure text activity, so we removed it.

At the same time, we should update adaptive inputs to set inputHint = expectingInput whenever we are issuing a prompt or reprompt (unrecognized/ invalid prompt).

@Danieladu Danieladu requested a review from cosmicshuai April 14, 2020 03:21
@coveralls
Copy link

coveralls commented Apr 14, 2020

Pull Request Test Coverage Report for Build 119814

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 67.112%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/input/inputDialog.ts 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/input/inputDialog.ts 1 7.41%
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 119752: -0.09%
Covered Lines: 10263
Relevant Lines: 14468

💛 - Coveralls

@Danieladu Danieladu merged commit 543fdb0 into master Apr 14, 2020
@Danieladu Danieladu deleted the hond/fix-prompt branch April 14, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] update adaptive inputs to set inputHint = expectingInput
3 participants